[Bug 221906] Review Request: gmediaserver - UPnP compatible media server for the GNU system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gmediaserver - UPnP compatible media server for the GNU system
Alias: gmediaserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221906





------- Additional Comments From karlikt at gmail.com  2007-03-22 16:30 EST -------
(In reply to comment #7)
> Obvious problems:
> * init file uses daemon function from initscripts but does not require
>   initscripts
Added

> * package can not assign static uid unless it's registered at this uid:
>   /usr/sbin/fedora-groupadd -r gmediaserver -u 105 &>/dev/null || :
>   /usr/sbin/useradd -c "gmediaserver" -u 105  \
Fixed
> * scriptlet used chkconfig but does not require it
>   Requires(post): /sbin/chkconfig
>   Requires(preun): /sbin/chkconfig
Added
> * please create backup patch files, ie:
>   %patch0 -p0 -b .mypatch
Updated
> * please use install to perform this.  specifically, you will want to look at
>   the -m (mode), -d (directory), -p (preserve timestamp), and -D (create leading
>   components):
>   mkdir -p $RPM_BUILD_ROOT%{_initrddir}
>   cp %{SOURCE1} $RPM_BUILD_ROOT%{_initrddir}/%{name}
>   chmod +x $RPM_BUILD_ROOT%{_initrddir}/%{name}
Updated
> * %define mediadir /var/gmediaserver
>   please read http://www.pathname.com/fhs/pub/fhs-2.3.html and determine the
>   proper location... perhaps /var/lib/gmediaserver?
Change to /srv/gmediaserver (consulted on IRC - #fedora-devel)
> * please use the correct macro for /var.  You can find any macros you need with
>   'rpm --showrc | grep /var'.  In this case, it's %{_localstatedir}:
>   /var/log/%{name}
Fixed
> * package used logrotate.d directory but does not require logrotate:
>   %config(noreplace) %{_sysconfdir}/logrotate.d/%{name}
Fixed
> * rpmlint is confused by your init file.  this is a bug in rpmlint though.
>   do you need to allow overrides for some of your variables:
>   pidfile=${PIDFILE-/var/run/gmediaserver.pid}
>   lockfile=${LOCKFILE-/var/lock/subsys/gmediaserver}
>   these should never change and would probably be better static unless you have
>   a good reason
Fixed
> * please consider adding the LSB bits (BEGING INIT INFO, END INIT INFO) to your
>   init file:
>  
>
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
Added
> * mixing fedora-groupadd / groupadd.  Decide on one or the other.  If you want
>   to use fedora-usermgmt, you must also put in the proper requires:
>   http://fedoraproject.org/wiki/PackageUserCreation
change to groupadd
> * chown in scriptlets:
>   set the uid/gid/mode in the %files section
Fixed

New urls:
http://karlik.nonlogic.org/gmediaserv/gmediaserver.spec
http://karlik.nonlogic.org/gmediaserv/gmediaserver-0.12.0-4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.