[Bug 221405] Review Request: libdirac - Dirac is an open source video codec

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 22 23:18:07 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libdirac - Dirac is an open source video codec


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221405


rpm at greysector.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |fedora-review?




------- Additional Comments From rpm at greysector.net  2007-03-22 19:18 EST -------
 1. package mostly meets naming and packaging guidelines.
    -> See comment #12.
    -> You could leave MMX optimizations enabled on x86_64 (assuming they work)
 2. specfile is properly named, is mostly cleanly written and uses macros
consistently.
    -> specfile contains a lot of commented-out code, please remove those parts
 3. dist tag is present.
 4. build root is sane.
 5. license field matches the actual license.
 6. license is open source-compatible (MPL). License text included in package.
 7. source files match upstream.
    Unable to verify md5sum because it's a snapshot, but diff -Nru between
    packaged tree and one checked out locally using the included script
    shows no differences.
 8. latest version is not being packaged, but I think it should be left
    at packager's discretion, as he should know which snapshot is stable.
 9. BuildRequires are proper.
10. package builds in mock (fc6/x86_64).
11. rpmlint is not silent, but these can be ignored:
    W: dirac-devel no-documentation
    E: dirac configure-without-libdir-spec
12. final provides and requires are sane:

dirac-0.6.0-6.20070108cvs.fc6.x86_64.rpm
libdirac_decoder.so.0()(64bit)  
libdirac_encoder.so.0()(64bit)  
dirac = 0.6.0-6.20070108cvs.fc6
=
/sbin/ldconfig  
/usr/bin/perl  
libc.so.6()(64bit)  
libdirac_decoder.so.0()(64bit)  
libdirac_encoder.so.0()(64bit)  
libgcc_s.so.1()(64bit)  
libm.so.6()(64bit)  
libstdc++.so.6()(64bit)  
perl(File::Basename)  
perl(Getopt::Long)  
perl(strict)  

dirac-devel-0.6.0-6.20070108cvs.fc6.x86_64.rpm
dirac-devel = 0.6.0-6.20070108cvs.fc6
=
dirac = 0.6.0-6.20070108cvs.fc6
libdirac_decoder.so.0()(64bit)  
libdirac_encoder.so.0()(64bit)  
pkgconfig  

13. shared libraries are present and handled properly
14. package is not relocatable.
15. owns the directories it creates.
16. doesn't own any directories it shouldn't.
17. no duplicates in %files.
18. file permissions are appropriate.
19. %clean is present.
20. test suite not included with snapshot, hence no %check
21. proper %post/%postun scriptlets present.
22. code, not content.
23. documentation is not small, -docs subpackage present.
24. %docs are not necessary for the proper functioning of the package.
25. headers in -devel
26. pkgconfig file in -devel, pkgconfig in Requires:
27. no libtool .la droppings.
28. GUI is not built/shipped, hence no .desktop file is necessary.
29. not a web app.

NEEDSWORK: 1, 2.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list