[Bug 233522] Review Request: nginx - http and reverse proxy server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nginx -   http and reverse proxy server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233522





------- Additional Comments From jeremy at hinegardner.org  2007-03-23 01:33 EST -------
(In reply to comment #3)
> 1. Not a blocker, just a suggestion, but you might want to change your Source0
> line from:
> Source0:    http://sysoev.ru/nginx/nginx-0.5.15.tar.gz
> to
> Source0:    http://sysoev.ru/nginx/nginx-%{version}.tar.gz
> 
> So you don't need to change it every release.

Fixed.
 
> 2. The upstream calls the license "BSD-Like"... should the License here
> be "BSD-Like" in the spec?

Fixed to: License: BSD-like 
 
> 3. rpmlint says:
> 
> E: nginx non-standard-uid /var/log/nginx nginx
> E: nginx non-standard-gid /var/log/nginx nginx
> E: nginx non-standard-uid /var/lib/nginx nginx
> E: nginx non-standard-gid /var/lib/nginx nginx
> 
> Can be ignored.
> 
> W: nginx strange-permission nginx.init 0775
> 
> You might make the init file in the src.rpm mode 644 and then install it with
> 755 perms? Not a blocker.

Fixed, nginx.int is 0644 in src.rpm and installs as 0755
 
> W: nginx rpm-buildroot-usage %build export DESTDIR=%{buildroot}
> 
> False positive.
> 
> E: nginx configure-without-libdir-spec
> 
> I see that you can't use %configure here, but you might add a comment
> about having to do so.

Comments about the patches added.  I will also be contacting upstream
source to see if they want to accept the patches.

> W: nginx mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1)
> 
> Pick tabs or spaces, don't mix.

Fixed.

> 4. Should the
> /usr/share/nginx/html
> be instead marked as %doc? which would put them under
> /usr/share/doc/nginx-%{version}/
> Or does it call those html files from the program?

Those files are served up by the program as default web pages and as
default error pages. 
> 5. The server doesn't start here after install... I get:
> 
> 2007/03/22 20:36:50 [emerg] 8189#0: glob() "/usr/share/nginx/conf/mime.types"
> failed (2: No such file or directory) in /etc/nginx/nginx.conf:18

Patch made to the default installed nginx.conf to make sure all the
paths are correct.

nginx starts correctly now, so long as something else isn't listening on port 80
(by default)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.