[Bug 230560] Review Request: wqy-bitmapfont - a fine-tuned CJK bitmap font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wqy-bitmapfont - a fine-tuned CJK bitmap font


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230560





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-23 05:01 EST -------
Well, the newest spec file is what I can see on
http://wenq.org/release/08src/wqy-bitmapfont.spec , right?

Then:
* At least this spec file cannot be accepted as this
  rpm creates some non-owned files. All files created or
  installed by this rpm should be owned by this rpm.
  i.e. Generally using "cp" or "ln" "rm" on scriptlets are 
       generally prohibited. This means that file ownership
       is somewhat wrong.

  If you have some strong reason why you want to support
  older versions, then IMO you should introduce %if macro, for example,
  and split the case accordingly.

* /usr/X11R6/ directory is no longer used.
  mkfontdir is now under %{_bindir}.

* Please use proper macros (i.e. %{_bindir} %{_sysconfdir},...)

* Please check what rpm owns %{_datadir}/fonts/wenquanyi/ .


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.