[Bug 233140] Review Request: paragui - Graphical User Interface based on SDL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: paragui - Graphical User Interface based on SDL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233140





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-23 14:22 EST -------
Well,  for 1.0.4-1:

?: Question
*: Must/Should fix

? Support bindings
  - It seems that python/ruby bindings are supported.
    However, when I tried to enable them, it failed due to
    some error...
    And I am not familiar with swig...

* Autotool
--------------------------------------------------
+ make
cd . && /builddir/build/BUILD/paragui-1.0.4/missing automake-1.4 --foreign
--include-deps Makefile
WARNING: `automake-1.4' is missing on your system.  You should only need it if
         you modified `Makefile.am', `acinclude.m4' or `configure.ac'.
         You might want to install the `Automake' and `Perl' packages.
         Grab them from any GNU archive site.
cd . \
          && CONFIG_FILES=Makefile CONFIG_HEADERS= /bin/sh ./config.status
--------------------------------------------------
  - Having autotools called after configure is wrong and
    must be fixed.
    Perhaps timestamps on some files are wrong.
    
* Timestamps
  - Please keep timestamps on the files which are not
    created or modified on build stage
    (i.e. which are contained in the source tarball and installed
          without any modification).
    Normally these are
    - Text files such as documentations, header files
    - image files
    - etc..
    For this package, the following works.
--------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
--------------------------------------------------

? automake .m4 files
  - I don't know if any conclusion was made about this, however
    should -devel package require "automake" for .m4 file?

* URL
  - And fix URL. 
    My firefox shows that when I tries to download src.tarball from 
   
http://www.bms-austria.com/projects/paragui/modules.php?op=modload&name=Downloads&file=index&req=viewdownload&cid=1
    it is redirected to gnu.org.

* rpmlint
---------------------------------------------------
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0
FT_Set_Char_Size
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0 FT_Load_Glyph
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0
FT_Done_FreeType
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0 FT_Get_Kerning
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0
FT_Init_FreeType
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0
FT_New_Memory_Face
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0
FT_Get_Char_Index
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0 FT_Done_Face
W: paragui undefined-non-weak-symbol /usr/lib/libparagui-1.0.so.0.4.0 FT_MulFix
W: paragui unused-direct-shlib-dependency /usr/lib/libparagui-1.0.so.0.4.0
/lib/libpthread.so.0
W: paragui unused-direct-shlib-dependency /usr/lib/libparagui-1.0.so.0.4.0
/usr/lib/libpng12.so.0
W: paragui unused-direct-shlib-dependency /usr/lib/libparagui-1.0.so.0.4.0
/usr/lib/libtiff.so.3
W: paragui unused-direct-shlib-dependency /usr/lib/libparagui-1.0.so.0.4.0
/usr/lib/libjpeg.so.62
W: paragui unused-direct-shlib-dependency /usr/lib/libparagui-1.0.so.0.4.0
/lib/libgcc_s.so.1
W: paragui-devel no-documentation
---------------------------------------------------
  - unused-direct-shlib-dependency can be ignored.
    However, undefined-non-weak-symbol cannot be ignored because
    this rpm provides -devel subpackage and linkage against libparagui-1.0
    fails due to this symbols.

* Requires
---------------------------------------------------
[tasaka1 at localhost ~]$ pkg-config --libs paragui
-lparagui -lSDL -lpthread -lSDL_image -lexpat -lfreetype -lstdc++  
[tasaka1 at localhost ~]$ pkg-config --cflags paragui
-D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/freetype2 -I/usr/include/SDL  
---------------------------------------------------
  - This means that -devel package should require SDL-devel, SDL_image-devel
    (and perhaps this is wrong).

    NOTE: if it is correct that "-lSDL" or "-I/usr/include/SDL" is included,
          then paragui.pc should have "Requires: sdl" (i.e. paragui.pc
          should require sdl.pc).
          And.. anyway paragui.pc should not have explicit
          "-l<which are in other packages>" entry. This entry usually means
          that linkage against libparagui-1.0 is incorrect.


--------------------------------------------------------------------
 I would appreciate it if you would review my review request for
 mecab-ipadic (bug 231486), which is very similar with mecab-jumandic.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.