[Bug 219097] Review Request: vdr-wapd - WAP daemon for VDR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vdr-wapd - WAP daemon for VDR


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219097





------- Additional Comments From ville.skytta at iki.fi  2007-03-24 13:01 EST -------
(In reply to comment #1)
>  * upstream not reachable atm; did it move?

No idea, it was there when I last checked not too long ago.  Sent mail upstream
asking what's up.

>  * the uid stuff rpmlint complains about is acceptable, but shouldn't it
> "Requires(pre): vdr", to make sure the users gets created before installation 
> of the plug-in?

No, there's no dependency loop present, so plain Requires: (on vdr(abi))
suffices.  Further, there's no %pre script that would require those users
(actually, no %pre script at all), so Requires(pre) wouldn't be quite correct
anyway. 
http://rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html#S3-RPM-DEPEND-FINE-GRAINED

>  * regarding the selinux comment in vdr-wapd-proxy.conf -- isn't there a
> possibility to make it "simply work" without offloading configuration to the 
> user?

I don't know, but I'd say it's a generic mod_proxy issue, not particularly a
vdr-wapd one.  Note that proxying is completely optional and the proxy snippet
is installed as a doc only to avoid a dependency on httpd, so user configuration
is required anyway if one wishes to do that.

>  * what's that "LIBDIR=." in the makefile? Looks suspicious; a comment might 
> be nice, if there is a good reasons for this (I suppose there is)

It's the same in all VDR plugins, just a directory where the compiled shared
object is copied into during build - VDR plugins have kind of a combined
build+install step (see Makefile and also the VDR plugin creator helper
scriptlet in /usr/bin/vdr-newplugin if you have vdr-devel installed).  Added a
one-liner comment about it.

http://cachalot.mine.nu/6/SRPMS/vdr-wapd.spec
http://cachalot.mine.nu/6/SRPMS/vdr-wapd-0.8-16.cmn6.src.rpm

* Sat Mar 24 2007 Ville Skyttä <ville.skytta at iki.fi> - 0.8-16
- Improvement suggestions from #219097: drop build dependency on sed,
  improve summary and description.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.