[Bug 230275] Review Request: varnish - High-performance HTTP accelerator

Sat Mar 24 20:04:31 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: varnish - High-performance HTTP accelerator

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230275

------- Additional Comments From kevin at tummy.com  2007-03-24 16:04 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
See below - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD-like)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
f942bfa029be8a9af9692a43bd04158c  varnish-1.0.3.tar.gz
f942bfa029be8a9af9692a43bd04158c  varnish-1.0.3.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have subpackages require base package with fully versioned depend.
See below - Should have dist tag
OK - Should package latest version

Issues:

1. You might want to use the %{?dist} tag. It makes things easier when you
are building the same version/release for multiple branches.
http://fedoraproject.org/wiki/Packaging/DistTag

2. You should not strip the binaries and libraries... that makes the rpm debuginfo
package empty. Remove the 'strip -p' lines in install.
rpmlint says:
E: varnish-debuginfo empty-debuginfo-package

3. Don't use $RPM_BUILD_ROOT and %{buildroot}. Pick one style and use just that one.

4. You might use for the Source0 url something like:
http://downloads.sourceforge.net/varnish/varnish-%{version}.tar.gz
Not a blocker, but nice to not point to a specific mirror.

5. You shouldn't need to specify Buildroot for each of the subpackages. It should
pick that up from the top. I think the comment above was about "BuildRequires", not
"Buildroot". Also, no need for another URL tag for the subpackages.

6. Do you need to ship static libs? They are discouraged in Fedora for a
variety of reasons. Do you know anything that links to just the static libs?
Or can we remove them for now and readd a -static subpackage later if someone
requests?

7.  Subpackages shouldn't also need to duplicate all the doc files:
%doc INSTALL LICENSE README ChangeLog redhat/README.redhat
Perhaps they should just be in the main package since the others require it?
Also, no need to include the INSTALL file, since people reading here will be
installing via the rpm. ;)

8. Does the description in the main package need to have all the links and
copyright info? The main url should be available via the URL tag, so not sure
if it's worth repeating there. Not sure we should also be pointing to
commercial support information either. They should be able to find that
off the main URL?

9. Should remove the
/sbin/chkconfig --list varnish
in %post. rpms shouldn't have any output when installing.
Also missing some requires for the init script handling, suggest:

Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig
Requires(preun): /sbin/service

10. You need to own the /etc/varnish directory...
%dir %{_sysconfdir}/varnish/

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.