[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: HippoDraw - Interactive and Python scriptable data analysis application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208034





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-25 02:49 EST -------
(In reply to comment #33)
> In regards to num_util.h:   Only in hippomodule.so (in the HippoDraw-python
> package is the num_util functions used.   So someone building an application
> with the libhippo.so and libhippoqt.so librareis the mulitple possible include
> in num_util.h should not matter.  

This explanation is good.

Well, then there are some other header files which contains the
following line:
--------------------------
#include "config.h"
--------------------------
They are:
--------------------------
/usr/include/HippoDraw/functions/FunctionBase.h
/usr/include/HippoDraw/minimizers/MinuitMigrad.h
/usr/include/HippoDraw/minimizers/NTupleLikeliHoodFCN.h
/usr/include/HippoDraw/minimizers/NTuplePearsonFCN.h
/usr/include/HippoDraw/minimizers/StatedFCN.h
/usr/include/HippoDraw/numarray/num_util.h
/usr/include/HippoDraw/python/FunctionWrap.h
/usr/include/HippoDraw/python/PyDataSource.h
/usr/include/HippoDraw/python/QtCut.h
--------------------------

Among them, some header files have #ifdef judgments for
HAVE_MINUIT2, HAVE_NUMARRAY, BOOST_DEFECT.
Would you check if all of the ifdef check for these values
are of no problem?

Well, I may have forgotton if any other issues are left,
so I will recheck this...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.