[Bug 233691] Review Request: clutter - Open Source software library for creating rich graphical user interfaces

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: clutter - Open Source software library for creating rich graphical user interfaces


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233691





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-25 15:37 EST -------
Created an attachment (id=150861)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=150861&action=view)
mock build log of clutter-0.2.2-2 on FC-devel i386

Very very quick comment
(well, I am currently reviewing more than 10 bugs and
 so please don't expect that I can review this package
 soon... I hope someone else would review this...)

* BuildRequires
  - mockbuild failed as attached. Please add
    the needed BuildRequires.

* Timestamps
  - Keep timestamps on files which are directly
    installed from tarball (header files, html, etc..)
    For this package, the following works
--------------------------------------------
make DESTDIR=$RPM_BUILD_ROOT install INSTALL="%{__install} -p"
--------------------------------------------

* Requires
  - Check the Requires for -devel package.
  * For header files, search the "#include" words
    and add the needed packages as Requires
    accordingly
    E.g. 
-----------------------------------
#include <glib-object.h>
-----------------------------------
    means that this header file should require
    glib2-devel
  - Also, check the "Requires" entry in .pc file.
-----------------------------------
Requires: pangoft2 glib-2.0 >= 2.8 gthread-2.0 gdk-pixbuf-2.0
gdk-pixbuf-xlib-2.0
------------------------------------
     requires some correspoinding packages.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.