[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher
Alias: jokosher

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029


snecklifter at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|needinfo?(snecklifter at gmail.|
                   |com)                        |




------- Additional Comments From snecklifter at gmail.com  2007-03-25 18:17 EST -------
(In reply to comment #73)
> (In reply to comment #70)
> > > BAD: The package does not follow the Naming Guidelines: The Release tag should
> > > be "0.%{X}.%{alphatag}" or equivalent as noted in the "Pre-Release packages"
> > > section of the naming guidelines (Packaging/NamingGuidelines on the wiki).
> > 
> > This should now be fixed as I have started bumping the %{X} section with each
> > new build.
> > 
> 
> That's still not correct. For pre-release snapshots, the final version from
> upstream will be Release 1, so everything before it must be Release 0.X, and
> with a suffix of the snapshot date tag too.

I must confess I find the Naming Guidelines a little confusing but hopefully the
current iteration meets them. I have tried to match it with the kismet example:

     kismet-0-0.1.20040110svn (this is a pre-release, svn checkout of kismet)

> Everything else looks fixed, with the exception of your dependencies: pycairo is
> a dependency of pygtk2, so you should remove the former.

Done.

> It's a minor issue, too, but for some parts in your %files section, you use the
> %name macro, yet in others you hardcode "jokosher." Is there a specific reason
> for this inconsistency?

Fixed.

> You just need to address these three issues, then it'll be approved. Thanks.

Looking forward to it.

www.iammetal.co.uk/jokosher

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.