[Bug 233585] Review Request: perl-XML-Writer - A simple Perl module for writing XML documents

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 26 06:28:37 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-XML-Writer - A simple Perl module for writing XML documents


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233585





------- Additional Comments From rc040203 at freenet.de  2007-03-26 02:28 EST -------
(In reply to comment #4)
> On a related note, I don't think testing for coverage of POD documentation is
> really that interesting at all from packaging point of view. 
Right, but it has always been our policy to enable them, when a perl-dist's test
suite uses them (More precisely: It has been policy to check everything a
test-suite can test for) 

I don't see any reason to make any exceptions.

(In reply to comment #6)
> (In reply to comment #3)
>    I thought its not much important as its only check section that said about
> skipping testing.
Checks aren't "only". We should "test to the max", if possible.

However you are right, Test::Pods aren't very important, but ... c.f. above.

Finally, another remark:
%check ||:

Remove the ||: - This is an anachronism to please "really ancient rpms" and has
been frowned upon for years. Use %check.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list