[Bug 223486] Review Request: happy - Haskell parser generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: happy - Haskell parser generator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223486





------- Additional Comments From petersen at redhat.com  2007-03-26 03:14 EST -------
Here is the review:

Good:
+ package and spec file are well named
+ meets Packaging Guidelines
+ package is open source (BSD-like)
+ license fields matches license and license file included in %doc
+ spec file is legible and in English
+ package built on i386
+ buildrequires listed
+ no translations
+ no libs included
+ owns its directories
+ no duplicates in filelist
+ has %clean
+ consistent use of macros
+ packages contains code
+ documentation small enough to be main package
+ no runtime files in %doc
+ no devel files
+ does not own dirs or files owned by other packages
+ installs and runs ok

Need attention:

- md5sum does not match upstream tarball, please use that
b9fd2f5eba61974dab8e12873cadee6f  happy-1.16.tar.gz

- rpmlint on srpm:
W: happy strange-permission happy.spec 0600
- rpmlint from binary package
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/expr-eval/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/expr-tree/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/packing/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/bio-eg/Bio.y
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/expr-monad/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/bio-eg/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/hidden-leftrec/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/nlp/Makefile
W: happy wrong-file-end-of-line-encoding
/usr/share/doc/happy-1.16/examples/glr/highly-ambiguous/Makefile

Maybe worth addressing: not sure how useful the examples are to include.
They could also be dropped?

- missing disttag
Please suffix %{?dist} to the release field.

- description
Maybe remove "or it can parse a stream of characters directly (but this isn't
practical in most cases)"?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.