[Bug 233942] Review Request: queuegraph - A RRDtool frontend for Mail statistics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: queuegraph - A RRDtool frontend for Mail statistics


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233942


jeremy at hinegardner.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |urgent
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From jeremy at hinegardner.org  2007-03-27 00:21 EST -------
(In reply to comment #3)
> (In reply to comment #2)
> > ISSUE - License See (1) below
> > 1) Only the queugraph.cgi is explicitly GPL the other scripts say nothing about
> 
> "other" script is queuegraph-rrd.sh
> 
> queuegraph-rrd.sh appears to have been originally posted here:
> http://archives.neohapsis.com/archives/postfix/2004-07/1527.html as mailqsize
> with no license information.
> 
> If this is a problem, I can rewrite it in perl :)
> 
> The 3 lines from the original program are: a) the location of postfix and b) the
> find over the 2 types of queues
> 
> Jason Thomas added the rrd file creation from create.sh.
> 
> I'm not sure any of this qualifies as original works.

Okay I agree, not sure what I was thinking.

> > a license and I was unable to find anything on the queuegraph website.  Maybe
> > talk to upstream about including a COPYING file ?
>  
> > 2) %dir needed for %{_datadir}/queuegraph
> 
> I'm using %{_datadir}/queuegraph so that the cgi file is included as well.  By
> not specifying %dir, I get directory ownership and file ownership in the glob. 
> 
> You can see that the directory is owned with 'rpm -qpl <package>'.

My Mistake, its good to learn something new.

It looks good so this package is APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.