[Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mrxvt - Multi-tabbed terminal emulator.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium




------- Additional Comments From jeremy at hinegardner.org  2007-03-27 02:08 EST -------
This is not an official review as I am not able to sponsor you. But this can get
you started. There are a considerable number of items at issue here.

You may want to read http://fedoraproject.org/wiki/Packaging/Guidelines

1) Source in src.rpm does not match upstream

3144a0cc066348557d2613b5cb2b4d14  mrxvt-0.5.2.tar.gz
ed87b7dd9f4fb482de0f14f085085027  mrxvt-0.5.2.tar.gz.1 (upstream)

2) Spec file and macros. I would suggest using rpmdevtools and starting
   anew with a fresh spec.

 a) %{buildroot} not %buildroot

 b) make use of %{_bindir}, %{_datadir}, %{_sysconfdir} in %files.

 c) all items listed in %files that are in /usrs/share/doc should be listed via %doc

 d) Items in /etc/ should be marked with %config 

 e) %defattr is required for %files section

 f) Source0 should be the full URL to the upstream source, in this case
 most likely
 http://downloads.sourceforge.net/materm/%{name}-%{version}.tar.gz

 Please see http://fedoraproject.org/wiki/Packaging/SourceURL

3) %clean must contain rm -rf %{buildroot}

4) mrxvt is a gui application and as such requires a .desktop file.

    http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

5) Fails to build in Mock.  This appears to be because if incorrect BuildRequires.




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.