[Bug 225925] Merge Review: jakarta-commons-dbcp

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 27 15:34:05 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: jakarta-commons-dbcp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225925


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium




------- Additional Comments From Jochen at herr-schmitt.de  2007-03-27 11:34 EST -------
Good:
+ Naming seems ok.
+ Package contains license text.
+ Mock build works fine.


Bad:
- Source0 contains not a full qualified URL
- Bad Buildroot
BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list