[Bug 234330] Review Request: ruby-cairo - ruby bindings for cairo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-cairo - ruby bindings for cairo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234330





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-03-28 12:21 EST -------
For 1.4.1-1:

* License
  - Well as Ruby uses "Ruby License/GPL", I would prefer
    to use it.

* Group
  - "Development/Languages" is for -devel package.
    For libraries, this should be "System Environment/Libraries"

* Release number specific dependency
  - Usually, provides or Requires for main package should be
    release number specific.

* Ownership
  - The following directories are not owned by any packages.
-------------------------------------------------
%{ruby_sitelib}/cairo/
%{ruby_sitelib}/cairo/context/
-------------------------------------------------
    NOTE:
    When you just write
-------------------------------------------------
%files
.....
foo/
-------------------------------------------------
    (where foo is a directory), this means the directory foo itself
    and all files/directories/etc under foo directory.

    While if you write
-------------------------------------------------
%files
......
%dir foo/
-------------------------------------------------
   This only contains the directory foo itself.

* Timestamps
  - Again keep timestamps on non-generated files.
    For this package, the following works.
-------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p"
-------------------------------------------------

* %check
  - Empty %check is not needed and please remove this.

* Requires
   - %{ruby_sitearch}/rb_cairo.h contains the line:
------------------------------------------------
    39  #include "ruby.h"
------------------------------------------------
     This means that -devel package needs "Requires: ruby-devel".

NOTE:
- When you update spec file, please describe briefly how
  you changed it in %changelog entry, not just write "Fix .spec".

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.