[Bug 234121] Review Request: PyOpenGL - Python bindings for OpenGL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyOpenGL - Python bindings for OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234121





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-03-29 06:22 EST -------
(In reply to comment #5)
> Well, for 3.0.0-0.1.a6:
> 
> * Executable permission vs shebang
> ---------------------------------------------------
> chmod +x $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/Tk/__init__.py \
>   $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/test_glgetfloat_leak.py \
>   $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/tests.py \
>   $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/test_glutinit_0args.py \
>   $RPM_BUILD_ROOT%{python_sitelib}/OpenGL/tests/test_glut_function_predef.py
> ---------------------------------------------------
>   - Well, please make it sure:
>     * If these scripts are expected to be called from other python
>       scripts and are not expected to be called "directly" by user
>       (well, "directly" used herein may be ambiguous), then
>       having shebang is wrong and these files should _not_ have
>       executable permission.
>     * If opposite, i.e. these scripts are meant to be called directly
>       by user, then these scripts should have executable permission.
> 
>     Usually the case is former.
> 

I will look into this.

> * Python related dependency
>   - Well, would you explain why the Requires for this package is
>     enough by the following?
> ---------------------------------------------------
> Requires:       python-numeric python-setuptools
> ---------------------------------------------------
> 
>     I usually check python related dependency by following. For this
>     package, it returns many dependency, such as
>     wxPython tkinter python-imaging pygame ... 
> 
> ---------------------------------------------------
> $ grep 'import ' `rpm -ql PyOpenGL | grep py$` | sed -e 's|^.*:||' | sed -e
> 's|^[ \t][ \t]*||' | sort | uniq
> ---------------------------------------------------
> 

Thanks, good tip, okay, so that gives me the following list of (non standard /
not already required) modules:
Tkinter (+ Dialog)
pygame
wxPython
Image

Correct?

Going through them one by one:
Image -> python-imaging, not needed, I've packaged up PyOpenGL for use with
  glchess, and that works fine without python-imaging, some texture loading 
  utility functions may need this, but I think its best to them make the 
  packages using those functions require python-imaging, to me PyOpenGL is an
  opengl wrapper and as such should require those bits which are absolutely 
  necessary todo that task.

pygame:
[hans at localhost glchess]$ grep -rl pygame /usr/lib/python2.5/site-packages/OpenGL
/usr/lib/python2.5/site-packages/OpenGL/tests/test_glgetfloat_leak.py
/usr/lib/python2.5/site-packages/OpenGL/tests/test_glgetfloat_leak.pyc
/usr/lib/python2.5/site-packages/OpenGL/tests/test_glgetfloat_leak.pyo
/usr/lib/python2.5/site-packages/OpenGL/tests/tests.py
/usr/lib/python2.5/site-packages/OpenGL/tests/testing_context.py
/usr/lib/python2.5/site-packages/OpenGL/tests/testing_context.pyc
/usr/lib/python2.5/site-packages/OpenGL/tests/testing_context.pyo
/usr/lib/python2.5/site-packages/OpenGL/tests/tests.pyc
/usr/lib/python2.5/site-packages/OpenGL/tests/tests.pyo

I've tried nuking the tests dir, but then using PyOpenGL fails with an import
error, so some bits are needed. Since pygame is only needed for tests I don't
want to require it.


tkinter:
[hans at localhost glchess]$ grep -irl Tkinter /usr/lib/python2.5/site-packages/OpenGL
/usr/lib/python2.5/site-packages/OpenGL/Tk/__init__.pyc
/usr/lib/python2.5/site-packages/OpenGL/Tk/__init__.py
/usr/lib/python2.5/site-packages/OpenGL/Tk/__init__.pyo

IOW only needed by applications which actually want to use the TK integration,
those should require tkinter themselves


wxpython:
[hans at localhost glchess]$ grep -irl wxPython /usr/lib/python2.5/site-packages/OpenGL
/usr/lib/python2.5/site-packages/OpenGL/tests/test_nolights.py
/usr/lib/python2.5/site-packages/OpenGL/tests/test_nolights.pyc
/usr/lib/python2.5/site-packages/OpenGL/tests/test_nolights.pyo
/usr/lib/python2.5/site-packages/OpenGL/tests/test_reported_leak.py
/usr/lib/python2.5/site-packages/OpenGL/tests/test_reported_leak.pyc
/usr/lib/python2.5/site-packages/OpenGL/tests/test_reported_leak.pyo

Idem as pygame


---

Before continuing I would like to hear from you what you think about this. 
I've removed all 4 of the above from my system and glchess still works fine, IOW
these really are optional, and thus in my vision should not be required.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.