[Bug 225628] Merge Review: bsh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: bsh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225628





------- Additional Comments From pcheung at redhat.com  2007-03-29 12:34 EST -------
(In reply to comment #2)
> Good:
> + Local build works fine.
> * Binaries packages are ok.
> + License ok.
> + naming seems ok.
> 
> Bad:
> - Rpmlint have warnings on source package:
> W: bsh non-standard-group Development/Java
The group is ok
> W: bsh strange-permission bsh-1.3.0-src.tar.bz2 0660
> W: bsh strange-permission bsh.spec 0660
> W: bsh strange-permission bsh-build.patch 0660
Fixed all the permission.
> - Unnecceasry BR
> uildRequires: perl should not be included
Got rid of it
>   (wiki: Packaging/Guidelines#Exceptions)
> - Surce0 doesn't contains a full-qualified URL
Source0 is created from cvs co, followed by creating the src tar ball, hence
there's no full-qualified URL for it.

Update spec file and srpm at the same location.
Thanks!
> 
> 
> 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.