[Bug 228298] Review Request: python-louie - Dispatches signals between Python objects in a wide variety of contexts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-louie - Dispatches signals between Python objects in a wide variety of contexts


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228298





------- Additional Comments From lxtnow at gmail.com  2007-03-30 11:28 EST -------
Well,

OK - Mock Build on FC-6 and FC-Devel (i386)
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License is BSD
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
46a61f7a88c624433c96f28ae30aa1a4  Louie-1.1.tar.gz
OK - Package has correct buildroot.
OK - BuildRequires isn't redundant.
OK - Sub-package is proper.
OK - %build and %install stages is correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Changelog section is correct.
OK - rpmlint output is silent on SRPM files.

----------
Rpmlint output from RPM package:

E: python-louie zero-length /usr/lib/python2.4/site-packages/louie/test/fixture.py
E: python-louie zero-length
/usr/lib/python2.4/site-packages/Louie-1.1-py2.4.egg-info/not-zip-safe

I don't consider these errors as blocker.
As there's no issue (yet ?) about empty files from packaging policy.
Perhaps upstream could be more explicit about why is the case.
For now, 
these errors can be ignored.

-------
About the BSD license, no see any included docs files in package include the BSD
license text or files.
except the index.txt file which mention that we can get it from website.
I don't think it's enough, the plain text of the license should be added in pakcage.


----------
APPROVED
----------

Add license file before request CVSsync

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.