[Bug 236162] Review Request: kadischi - Fedora based LiveCD/LiveDVD creation utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadischi - Fedora based LiveCD/LiveDVD creation utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236162





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-01 12:20 EST -------
Created an attachment (id=153866)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=153866&action=view)
mock build log of kadischi-3.5-3 on FC-devel i386

Sorry, the previous my comment was a draft. Please ignore
it...

(In reply to comment #17)
> (In reply to comment #16)
> > Just from I checked your spec file:
> > 
> > * Some of the directories which should be owned by
> >   this package are actually not owned.
> Can you specify which directories you are talking about?
They are:
--------------------------------------------------
%{_datadir}/%{name}/lib/
%{_datadir}/%{name}/post_install_scripts/
%{_datadir}/%{name}/initrd/
%{_datadir}/%{name}/ks_examples/
.........
---------------------------------------------------
Not only the files under these directories but also these
directories themselves must be owned.

NOTE: When you write:
-------------------------------------
%files
%defattr(-,root,root,-)
%dir foo/
-------------------------------------
(where foo/ is a directory), this means the directory
foo/ only, where when you write
-------------------------------------
%files
%defattr(-,root,root,-)
foo/
-------------------------------------
this means the directory foo/ itself and all
files/directories/etc.. under foo/.

> > * Please specify the full URL of the source or provide the
> >   way we can get the source of this package.
> The URL is a pointer to the Wiki page on FedoraProject.org where it can be
> retrieved using CVS.

In this case, you have to write as comments how
you created the source tarball (please check the section
"Using Revision Control" of
http://fedoraproject.org/wiki/Packaging/SourceURL .
And in that case, it is mandatory that the date when
you created the tarball by cvs is included into release number.

http://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages


And mockbuild failed on FC-devel i386. The build log shows
that -lz is needed on some compiling.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.