[Bug 236162] Review Request: kadischi - Fedora based LiveCD/LiveDVD creation utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadischi - Fedora based LiveCD/LiveDVD creation utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236162





------- Additional Comments From cgoorah at yahoo.com.au  2007-05-01 13:25 EST -------
(In reply to comment #17)
> The URL is a pointer to the Wiki page on FedoraProject.org where it can be
> retrieved using CVS.

True.
However I guess you misunderstood me for the %{?dist}, which confused Mamuro 
that you pulled the kadischi sources from the cvs.

Your Release: should be 
Release:        3{alphatag}%{?dist}


> Yes, System/Applications is correct to my knowledge, since there is no
> development package associated with this package, nor is it built against in 
any form or fashion. It isn't an IDE for programming, or any sort of compiler.

I chose System/Applications for kadischi for the same reason that Jasper 
explained.

(In reply to comment #19)
> -------------------------------------
> %files
> %defattr(-,root,root,-)
> foo/
> -------------------------------------
> this means the directory foo/ itself and all
> files/directories/etc.. under foo/.

In this case the %files section can be reduced to:

%files
%defattr(-,root,root,-)
%doc FAQ README TODO COPYING CREDITS
%{_datadir}/%{name}
%{_libexecdir}/%{name}
%{_sbindir}/%{name}
%dir %{_sysconfdir}/%{name}
%config(noreplace) %{_sysconfdir}/%{name}/buildstamp
%config(noreplace) %{_sysconfdir}/%{name}/%{name}.conf
%{_mandir}/man1/%{name}.1.gz
%{_mandir}/man5/%{name}.conf.5.gz

> And mockbuild failed on FC-devel i386. The build log shows
> that -lz is needed on some compiling.
> 

libz-devel is missing as BR.

Below is from the rpmbuild:
[...]
/usr/bin/install -c -m 
644 'userhome.desktop' '/var/tmp/kadischi-3.5-2.20070501cvs-root-chitlesh/usr/share/kadischi/desktop/userhome.desktop'
 /usr/bin/install -c -m 
644 'userhome.sh' '/var/tmp/kadischi-3.5-2.20070501cvs-root-chitlesh/usr/share/kadischi/desktop/userhome.sh'
 /usr/bin/install -c -m 
644 'install.desktop' '/var/tmp/kadischi-3.5-2.20070501cvs-root-chitlesh/usr/share/kadischi/desktop/install.desktop'
[...]

You can see that that the "-p" argument is missing which for preserving 
timestamps. Timestamps should be preserved.

This can be done by using
make INSTALL="install -p" DESTDIR=%{buildroot} install
instead of
make install DESTDIR=%{buildroot}


Another thing the package entails an empty folder: 
/usr/share/kadischi/patches

Actually when I was maitaining kadischi with you, Jasper, this folder 
contained patches for kadischi itself. However for a user using kadischi it is 
useless. Please, correct me if that has changed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.