[Bug 230560] Review Request: wqy-bitmap-fonts - a fine-tuned Chinese bitmap font

bugzilla at redhat.com bugzilla at redhat.com
Wed May 2 00:31:04 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wqy-bitmap-fonts - a fine-tuned Chinese bitmap font


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230560





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-01 20:31 EST -------
What is the status of this bug?
For current spec file:

* Versioning
  - I suggest again that the version of this spec/srpm should be
    0.8.1.7. 

* Requires:
---------------------------------------------
Requires(post): chkfontpath
Requires(postun): chkfontpath
---------------------------------------------
  - If you add this Requires, then the check of the existence on
    the scriptlets:
---------------------------------------------
    [ -f %{_bindir}/mkfontdir ]    && 
---------------------------------------------
    is not needed because you explicitly "require" it.
    IMO the binaies
---------------------------------------------
%{_bindir}/mkfontdir
%{_bindir}/fc-cache
%{_sbindir}/chkfontdir
---------------------------------------------
    should be added as Requires(post) or/and Requires(postun),
    and all checking part "like [ -f <> ] && " should be removed.

* Conflict
  - I still don't understand why you add the line
---------------------------------------------
Conflicts: x11-font-wqy-bitmapfont
---------------------------------------------
    Are the rpm "x11-font-wqy-bitmapfont" ever shipped *on Fedora*?
    If not, then this line should be removed.

* Provides:
---------------------------------------------
Provides: wqy-bitmap-fonts = %{version}-%{release}
---------------------------------------------
    - This is not needed. This is automatically added.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list