[Bug 235191] Review Request: postr - Flickr uploader
bugzilla at redhat.com
bugzilla at redhat.com
Thu May 3 09:06:27 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: postr - Flickr uploader
------- Additional Comments From trond.danielsen at gmail.com 2007-05-03 05:06 EST -------
(In reply to comment #10)
> rpmlint srpm only minor warning:
> W: postr mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 46)
> Nuke the tabs in the whitespace of the desktop file install command and this
> goes away.
> Application appears to function for me as anticipated. Photos were uploaded,
> there was much rejoicing.
> The BAD
> - SOURCE1 instructions do not produce tarball with matching md5sum. Not sure
> what's going on here. I can confirm that repeated tar czf gives different
> md5sums. But tar cf gives me something reproducible.
> So if i decompress the included tarball I still get a md5sum on postr-icons.tar
> compared to the one i create with bzr and tar cf data setup.py. Double check to
> see if you can get consistent comparisons against the tar file instead of the
tar cf [...] produces consistent results, so this should be FIXED now.
> - base package must own all directories it creates and directory ownership of
> parent directories is accounted for in package deps
> Problem: /usr/share/icons/hicolor/*/apps/ not owned by a required dep.
> Solution: adds Requires: hicolor-icon-theme
> Problem: /usr/lib/nautilus/extensions-1.0/python is not owned by any package.
> Suggested Solution: make the nautilus-python package create and own this
> directory. Fix is outside the scope of this review. But if you can commit a fix
> to the python-nautilus package with this fix , it will clear up the issue here.
This has already been reported to bz and fixed :). See
> Do you really want to pull in python-twisted or do you want to pull in only a
> subset of the twisted packages? Looking over the python code in postr it looks
> like you technically only need to require python-twisted-core and
> python-twisted-web, instead of the metapackage python-twisted.
I changed the requirements, and it works just fine. FIXED.
> So overall, pretty close to being approvable... that gzip behavior seems odd
Strange, but the uncompressed tar works...
New versions at the same location as the previous ones.
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review