[Bug 222888] Review Request: Tiquit - A PHP5-compatible help desk incident tracking/knowledgebase system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Tiquit - A PHP5-compatible help desk incident tracking/knowledgebase system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222888


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2007-05-06 03:11 EST -------
Builds fine and rpmlint is silent.

Source0 should be a URL; I used the usual
  http://dl.sf.net/%{name}/%{name}-%{version}.tar.gz
so that I could grab the upstream source for comparison.

The link to config.php looks a bit odd:
  /usr/share/tiquit/config.php -> ../../..//etc/tiquit/config.php
%{_sysconfdir} includes a leading slash.  Normally I'd ask if there's a nicer
way to do this than via a symlink, but it's pretty obvious from the code that
you'd have to patch every source file.

Since this comes up locked down to localhost, it's probably worth adding a
README.Fedora file containing information about why you've done that, what the
user needs to in order to enable things, and if there's any mandatory
configuration they need to do before turning it on.

I'm not sure your dependency on php-gd does what you want it to.  Note that it
won't pull in a PHP interpreter, just php-common.

I'm not sure why you have
  %dir %{tiquitdir}
  %{tiquitdir}/*
instead of just
  %{tiquitdir}

* source files match upstream:
   1c7aefbde49ee7ee4f946d60218a9f19f5a5236df67f3e401ffa76f2ecfc563c  
   tiquit-2.4.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none needed)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
? final provides and requires are sane:
   config(tiquit) = 2.4-1.fc7
   tiquit = 2.4-1.fc7
  =
   config(tiquit) = 2.4-1.fc7
   php-gd

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.