[Bug 233596] Review Request: coherence - Python framework to participate in digital living networks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: coherence - Python framework to participate in digital living networks


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233596





------- Additional Comments From lxtnow at gmail.com  2007-05-07 10:13 EST -------
Yep,

OK - Mock Build on FC-Devel (noarch package
OK - Package meets naming and packaging guidelines
 ? - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License is MIT
OK - License text is present in the package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
0cc1e8dbcb0d30a7cdce0bf64cb7b4ff  Coherence-0.1.0.tar.gz
OK - Package has correct buildroot.
OK - BuildRequires isn't redundant.
OK - %build and %install stages is correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - No Scriplets is required for this package.
OK - %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Changelog section is correct.
OK - rpmlint is silent on both SRPM and RPM files.

------

Just one comment:
Base package name is Coherence ( with an uppercase letter ) and your pre-built
package name start with an lowercase letter.
It doesn't match the packaging naming guideline.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.