[Bug 239435] Review Request: Gnome Network Monitor - A Network Monitor for the GNOME Desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Gnome Network Monitor - A Network Monitor for the GNOME Desktop


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239435


Jochen at herr-schmitt.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |Jochen at herr-schmitt.de
               Flag|                            |fedora-review?




------- Additional Comments From Jochen at herr-schmitt.de  2007-05-08 12:11 EST -------
Good:
+ Naming seems ok.
+ Rpmlint quite on source rpm.
+ Local build works fine.
+ Mock build works fine.


Bad:
- Source0 contains not a full qualified URL.
- %{?_smp_mflags} missing on make without any comment.
- /usr/bin should be replace by %{_bindir}
- /usr/sbin should be replace by %{_sbindir}
- /ussr/share should be replace by %{_datadir}
You can owned a whole directory, if the entry in the %file stanza end with a slash
- Rpmlint complaints binary package:
W: gnome-network-monitor no-documentation
E: gnome-network-monitor script-without-shebang
/usr/share/gnome-network-monitor/gnm.glade
W: gnome-network-monitor conffile-without-noreplace-flag
/etc/pam.d/gnome-network-monitor
W: gnome-network-monitor conffile-without-noreplace-flag
/etc/security/console.apps/gnome-network-monitor
- Packages contains no docs.
- Package doesn't contain a verbatin copy of the license text
- Programm crashed after startup:
/usr/lib/python2.4/site-packages/gnome-network-monitor/gnm.py:69: GtkWarning:
gtk_widget_grab_default: assertion `GTK_WIDGET_CAN_DEFAULT (widget)' failed
  self.__xml_file     =  gtk.glade.XML(self.__glade_file, "gnome-network-monitor")
Updating information
Traceback (most recent call last):
  File "/usr/sbin/gnome-network-monitor", line 10, in ?
    gnm.run()
  File "/usr/lib/python2.4/site-packages/gnome-network-monitor/gnm.py", line
134, in run
    win = MainWindow()
  File "/usr/lib/python2.4/site-packages/gnome-network-monitor/gnm.py", line 97,
in __init__
    self.__iptables.parse_file()
  File "/usr/lib/python2.4/site-packages/gnome-network-monitor/iptables.py",
line 145, in parse_file
    self.__insert_record(FwRecord(line))       # store them in the db
  File "/usr/lib/python2.4/site-packages/gnome-network-monitor/iptables.py",
line 32, in __init__
    tup = time.strptime("%s %s %s"%(lfs[0], lfs[1], lfs[2]), "%b %d %H:%M:%S")
  File "/usr/lib64/python2.4/_strptime.py", line 293, in strptime
    raise ValueError("time data did not match format:  data=%s  fmt=%s" %
ValueError: time data did not match format:  data=May 7 19:08:04  fmt=%b %d %H:%M:%S






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.