[Bug 238248] Review Request: ddccontrol - TFT monitor parameters control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ddccontrol - TFT monitor parameters control


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238248





------- Additional Comments From wolfy at nobugconsulting.ro  2007-05-08 16:29 EST -------
Just a few comments, after a quick glance. Note that I cannot sponsor you, so I
am not assigning the package to me.
- BuildRoot is not one of the values imposed by
http://fedoraproject.org/wiki/Packaging/Guidelines
- gcc-c++ is part of the default build env, so there is no need to BR it
- % make and %install should start by cleaning the buildroot
- you should use (if possible) parallel make for building; if SMP build is
non-functional, this should be mentioned in the spec
- mock build fails with:
checking pci/pci.h usability... yes
checking pci/pci.h presence... yes
checking for pci/pci.h... yes
checking for pci_alloc in -lpci... no
configure: error: PCI utils library not found, please install pci-utils.
error: Bad exit status from /var/tmp/rpm-tmp.22865 (%build)

I admit I am surprised by this error, since according to the root.log both
pciutils and pciutils-devel are installed.
- please make sure that you do not need gettext as a BR (you seem to build
translations and this is a BR for them) or add it if you do.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.