[Bug 239154] Review Request: referencer - A document organiser and bibliography manager for Gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: referencer - A document organiser and bibliography manager for Gnome 


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239154





------- Additional Comments From kmatsui at t3.rim.or.jp  2007-05-09 05:10 EST -------
Created an attachment (id=154382)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=154382&action=view)
mock-referencer-build.log

I am not yet a package-maintainer.
This is my "pre-review" to exercise reviewing.
I checked this package as follows.

rpmlint is silent on both of this SRPM and the generated binary package.

package name:	reference:		OK.
spec file name: reference.spec: 	OK.
license:	GPL:
	%license field matches the actual license,
	COPYING is listed in %doc,	OK.
spec file:	written in English, legible:		OK.
upstream source:
	http://icculus.org/referencer/downloads/referencer-1.0.3.tar.gz:
	md5sum:1179e0eafc17ef130b8d669255bef0b3
source: 	referencer-1.0.3.tar.gz:
	md5sum:1179e0eafc17ef130b8d669255bef0b3,
	matches to the upstream source, OK.
build:	mock successfully built this package on fc-6/i386,
	see the attached build.log,	OK.
BuildRequires:	poppler-devel libgnomeuimm26-devel boost-devel gcc-c++
		gettext perl(XML::Parser) desktop-file-utils:
	all required packages are listed, so mock builds successfully,	OK.
locale handling:
	by %find_lang %{name}, not by %{_datadir}/locale/*:	OK.
%prefix:	not used:		OK.
shared library problem: 	not installed:		OK.
ownership of directories and files:
	all listed under %doc, ${_bindir} and ${_datadir}:	OK.
owning directories created by other packages:		none:	OK.
duplicate listing in %file:	none:	OK.
%defattr:	(-,root,root,-):	OK.
at the beginning of %install:
		rm -rf %{buildroot}:	OK.
%clean: 	rm -rf %{buildroot}	OK.
usage of macros:	consistent:	OK.
desktop file:
	%{name}.desktop is installed with desktop-file-install in %install:
	OK.
%post, %postun:
	update desktop database, mime database and icon cache:
	OK.

This packaging seems to be complete!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.