[Bug 232792] Review Request: mapserver - Environment for building spatially-enabled internet applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mapserver - Environment for building spatially-enabled internet applications


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232792





------- Additional Comments From cbalint at redhat.com  2007-05-10 11:52 EST -------
(In reply to comment #19)
> Well, for 4.10.2-1:
> 
> * Dependency for main package:
>   - Well, for unknown reason I didn't notice, however
>     none of 4 subpackages have no dependency for main
>     (mapserver) package. Please check if this is correct.

updated.
php one not require this, it embed everything inside that apache
module, so thats exception.

> 
>     IMO at least perl/python/java binding subpackage should
>     have the release number dependent dependency for main
>     package (i.e. should have: 
>     "Requires: %{name} = %{version}-%[release}").
yes updated.

> 
> * Source
>   - The URL of the source returns "not found". Maybe:
>     http://download.osgeo.org/mapserver/mapserver-4.10.2.tar.gz ?
umm, updated. (they changed truely)

> 
> * (minor) Macros
>   - /usr/sbin/ can be replaced with %{_sbindir} (preferred)
>   - And in the line "mkdir -p %{buildroot}/etc/php.d" 
>     /etc should be %{_sysconfdir}
updated every places.

> 
> Other things are okay.

Thank you Tasaka !

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.