[Bug 238562] Review Request: machineball - A futuristic ball game with simple rules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: machineball - A futuristic ball game with simple rules


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238562





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-05-10 15:34 EST -------
(In reply to comment #6)
> THINGS TO DO:
>  - add missing BR: mesa-libGLU-devel
Done
>  - add at least %{version} to Source0 tag
>  - upload proper source code file to srpm (current one has a wrong name)
Source0 url fixed and changed to use %{name} and %{version}. I started this
packaged based on a srpm send to me by someone who had read on my wikipage that
I was interested on this, he renamed the tarbal (and I didn't check).


> The last issue forces change of versioning. Probably you can just replace "-" 
> with ".", but if aby other (better) ideas are very welcome.

The fix is easy, the real version is 1.0, the added -1 in the src tarbal is
because upstream uses binary rpms as their primary distribution method, and they
don't know what the release field is for, so they add it to their source tarbals
too. I've seen this confused behaviour by other upstreams too, for example with
blobwars.


New version with all this fixed here:
Spec URL: http://people.atrpms.net/~hdegoede/machineball.spec
SRPM URL: http://people.atrpms.net/~hdegoede/machineball-1.0-2.fc7.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.