[Bug 225522] Review Request: cinepaint - CinePaint is a tool for manipulating images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cinepaint - CinePaint is a tool for manipulating images


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225522


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
OtherBugsDependingO|163776                      |163778
              nThis|                            |
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-11 14:50 EST -------
Well, I use rawhide and so I have not checked on
FC-6.

On rawhide, 0.22.0-2 contained several problems.

-----------------------------------------------------------
* Compilation
  - Actually
> yes indeed...(was still working on it but was still 
> failling on icc_examin on devel). 
    This needs a patch (Patch0)

* Directory ownership issue
  - Some directories were owned properly.

* Undefined non-weak symbols
  - Some libraries in cinepaint contained undefined non-weak
    symbols. 
    This cannot be accepted for a package which provides
    -devel subpackage because leaving these symbols leads to
    linkage failure

* Unnecessary/missing (Build)Requires
* Unnecessary %Requires(postun) etc
* Use of binaries for priviledged user
  - Binaries for priviledged user (i.e. binaries under
    /sbin /usr/sbin etc..) must be specified by full path.
    Otherwise, calling these binaries fails on sudo user,
    for example.

* More pkgconfig .pc file fix was needed
* More proper fix for rpath was recommended
  - i.e. don't use chrpath when possible
* Unneeded autoconf call
* Timestamp keeping
* desktop file fix
* Requires:
  - What does "Requires: freefont" mean?? On my system no package
    provides freefont. 
* Build log should be more verbose
-----------------------------------------------------------

I hope I fixed the issues above.
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/cinepaint.spec
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/cinepaint-0.22.0-3.fc7.src.rpm

mock build on FC-devel i386 is successful.
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-cinepaint.log

Please check if my spec/srpm is what you expect. If you notice
something, please fix/modify my spec/srpm and upload your spec/srpm

-----------------------------------------------------------
NOTE
There are still some items I have to check for this package.
My package may have some problem, so please check my spec/srpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.