[Bug 238211] Review Request: perl-Catalyst-Runtime - Catalyst core modules
bugzilla at redhat.com
bugzilla at redhat.com
Tue May 15 03:34:02 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Runtime - Catalyst core modules
Alias: Catalyst-Runtime
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238211
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade at gmail.com 2007-05-14 23:33 EST -------
As package is having circular deps on -Devel package, make test easily skipped
-devel tests as seen in given below make test output.
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2d4d22d4153b49d64ed715bfd81d809d Catalyst-Runtime-5.7007.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/01use.t t/02pod.t t/03podcoverage.t
t/c3_mro.t t/custom_live_component_controller_action_auto_doublebug.t
t/live_component_controller_action_action.t
t/live_component_controller_action_auto.t
t/live_component_controller_action_begin.t
t/live_component_controller_action_chained.t
t/live_component_controller_action_default.t
t/live_component_controller_action_detach.t
t/live_component_controller_action_end.t
t/live_component_controller_action_forward.t
t/live_component_controller_action_global.t
t/live_component_controller_action_index.t
t/live_component_controller_action_inheritance.t
t/live_component_controller_action_local.t
t/live_component_controller_action_multipath.t
t/live_component_controller_action_path.t
t/live_component_controller_action_private.t
t/live_component_controller_action_regexp.t
t/live_component_controller_action_streaming.t
t/live_component_controller_args.t t/live_engine_request_body.t
t/live_engine_request_cookies.t t/live_engine_request_headers.t
t/live_engine_request_parameters.t t/live_engine_request_uploads.t
t/live_engine_request_uri.t t/live_engine_response_cookies.t
t/live_engine_response_errors.t t/live_engine_response_headers.t
t/live_engine_response_large.t t/live_engine_response_redirect.t
t/live_engine_response_status.t t/live_engine_setup_basics.t
t/live_engine_setup_plugins.t t/live_fork.t t/live_loop.t t/live_plugin_loaded.t
t/live_priorities.t t/live_recursion.t t/optional_http-server-restart.t
t/optional_http-server.t t/optional_lighttpd-fastcgi-non-root.t
t/optional_lighttpd-fastcgi.t t/optional_memleak.t t/optional_stress.t
t/optional_threads.t t/unit_controller_config.t t/unit_controller_namespace.t
t/unit_core_action_for.t t/unit_core_component.t t/unit_core_component_layers.t
t/unit_core_component_loading.t t/unit_core_log.t
t/unit_core_merge_config_hashes.t t/unit_core_mvc.t t/unit_core_path_to.t
t/unit_core_plugin.t t/unit_core_uri_for.t t/unit_core_uri_for_action.t
t/unit_load_catalyst_test.t t/unit_utils_load_class.t t/unit_utils_prefix.t
t/unit_utils_request.t
t/01use.....................................................ok
t/02pod.....................................................ok
t/03podcoverage.............................................ok
t/c3_mro....................................................ok
t/custom_live_component_controller_action_auto_doublebug....ok
t/live_component_controller_action_action...................ok
t/live_component_controller_action_auto.....................ok
t/live_component_controller_action_begin....................ok
t/live_component_controller_action_chained..................ok
t/live_component_controller_action_default..................ok
t/live_component_controller_action_detach...................ok
t/live_component_controller_action_end......................ok
t/live_component_controller_action_forward..................ok
t/live_component_controller_action_global...................ok
t/live_component_controller_action_index....................ok
t/live_component_controller_action_inheritance..............ok
t/live_component_controller_action_local....................ok
t/live_component_controller_action_multipath................ok
t/live_component_controller_action_path.....................ok
t/live_component_controller_action_private..................ok
t/live_component_controller_action_regexp...................ok
t/live_component_controller_action_streaming................ok
t/live_component_controller_args............................ok
t/live_engine_request_body..................................ok
t/live_engine_request_cookies...............................ok
t/live_engine_request_headers...............................ok
t/live_engine_request_parameters............................ok
t/live_engine_request_uploads...............................ok
t/live_engine_request_uri...................................ok
t/live_engine_response_cookies..............................ok
t/live_engine_response_errors...............................ok
t/live_engine_response_headers..............................ok
t/live_engine_response_large................................ok
t/live_engine_response_redirect.............................ok
t/live_engine_response_status...............................ok
t/live_engine_setup_basics..................................ok
t/live_engine_setup_plugins.................................ok
t/live_fork.................................................ok
t/live_loop.................................................ok
t/live_plugin_loaded........................................ok
t/live_priorities...........................................ok
t/live_recursion............................................ok
t/optional_http-server-restart..............................skipped
all skipped: Catalyst::Devel required
t/optional_http-server......................................skipped
all skipped: Catalyst::Devel required
t/optional_lighttpd-fastcgi-non-root........................skipped
all skipped: Catalyst::Devel required
t/optional_lighttpd-fastcgi.................................skipped
all skipped: Catalyst::Devel required
t/optional_memleak..........................................skipped
all skipped: set TEST_MEMLEAK to enable this test
t/optional_stress...........................................ok
t/optional_threads..........................................ok
t/unit_controller_config....................................ok
t/unit_controller_namespace.................................ok
t/unit_core_action_for......................................ok
t/unit_core_component.......................................ok
t/unit_core_component_layers................................ok
t/unit_core_component_loading...............................ok
t/unit_core_log.............................................ok
t/unit_core_merge_config_hashes.............................ok
t/unit_core_mvc.............................................ok
t/unit_core_path_to.........................................ok
t/unit_core_plugin..........................................ok
t/unit_core_uri_for.........................................ok
t/unit_core_uri_for_action..................................ok
t/unit_load_catalyst_test...................................ok
t/unit_utils_load_class.....................................ok
t/unit_utils_prefix.........................................ok
t/unit_utils_request........................................ok
All tests successful, 8 tests skipped.
Files=66, Tests=2683, 101 wallclock secs (74.57 cusr + 4.61 csys = 79.18 CPU)
+ Provides: perl(Catalyst) = 5.7007 perl(Catalyst::Action)
perl(Catalyst::ActionChain) perl(Catalyst::ActionContainer)
perl(Catalyst::AttrContainer) perl(Catalyst::Base) perl(Catalyst::Build)
perl(Catalyst::Component) perl(Catalyst::Controller)
perl(Catalyst::DispatchType) perl(Catalyst::DispatchType::Chained)
perl(Catalyst::DispatchType::Default) perl(Catalyst::DispatchType::Index)
perl(Catalyst::DispatchType::Path) perl(Catalyst::DispatchType::Regex)
perl(Catalyst::Dispatcher) perl(Catalyst::Engine) perl(Catalyst::Engine::CGI)
perl(Catalyst::Engine::FastCGI) perl(Catalyst::Engine::HTTP)
perl(Catalyst::Engine::HTTP::Restarter)
perl(Catalyst::Engine::HTTP::Restarter::Watcher) perl(Catalyst::Exception)
perl(Catalyst::Exception::Base) perl(Catalyst::Log) perl(Catalyst::Model)
perl(Catalyst::Request) perl(Catalyst::Request::Upload) perl(Catalyst::Response)
perl(Catalyst::Runtime) perl(Catalyst::Test) perl(Catalyst::Utils)
perl(Catalyst::View)
+ Requires: perl(:MODULE_COMPAT_5.8.8) perl(CGI::Simple::Cookie) perl(Carp)
perl(Catalyst::Action) perl(Catalyst::ActionChain)
perl(Catalyst::ActionContainer) perl(Catalyst::Controller)
perl(Catalyst::DispatchType::Default) perl(Catalyst::DispatchType::Index)
perl(Catalyst::Engine::HTTP::Restarter)
perl(Catalyst::Engine::HTTP::Restarter::Watcher) perl(Catalyst::Exception)
perl(Catalyst::Log) perl(Catalyst::Request) perl(Catalyst::Request::Upload)
perl(Catalyst::Response) perl(Catalyst::Utils) perl(Class::Accessor::Fast)
perl(Class::Data::Inheritable) perl(Class::Inspector) perl(Config)
perl(Data::Dump) perl(Devel::InnerPackage) perl(Errno) perl(File::Copy)
perl(File::Find) perl(File::Modified) perl(File::Spec) perl(File::Spec::Unix)
perl(File::stat) perl(HTML::Entities) perl(HTTP::Body) perl(HTTP::Date)
perl(HTTP::Headers) perl(HTTP::Request) perl(HTTP::Status) perl(IO::File)
perl(IO::Select) perl(IO::Socket) perl(IO::Socket::INET) perl(Module::Build)
perl(Module::Pluggable::Object) perl(NEXT) perl(Path::Class)
perl(Path::Class::Dir) perl(Path::Class::File) perl(Scalar::Util) perl(Socket)
perl(Text::Balanced) perl(Text::SimpleTable) perl(Time::HiRes)
perl(Tree::Simple) perl(Tree::Simple::Visitor::FindByPath)
perl(Tree::Simple::Visitor::FindByUID) perl(URI) perl(URI::QueryParam)
perl(attributes) perl(base) perl(bytes) perl(constant) perl(overload)
perl(strict) perl(utf8) perl(vars) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list