[Bug 239978] Review Request: ants - Guide your ants safely home before they drop of the cliff

bugzilla at redhat.com bugzilla at redhat.com
Wed May 16 12:55:17 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ants - Guide your ants safely home before they drop of the cliff


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239978





------- Additional Comments From limb at jcomserv.net  2007-05-16 08:55 EST -------
rpmlint is clean, with one exception:

W: ants-level-editor no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.

But, then, I don't see any docs specific to it, so never mind.
Meets package naming guidelines.
Spec name is good.
Meets Packaging Guidelines.
License was originally unspecified, but license-info includes dialog with
upstream who declared it Public Domain.
Spec is legible American English.
Sources md5 match.
Builds on i386/FC6 and in mock, as well.
BRs are OK.
No locales, shared libraries or static libraries.
Not relocatable.
Owns created directories.
No listed duplicates.
Permissions/defattrs correct.
%clean present and correct.
Good macros.
Code, not content.
No large docs or runtime doc deps.
No headers or .pc.
No -devel.
No .la.

.desktop is good. However, might not a .desktop for -level-editor be helpful?

No ownership conflicts.
Install begins by whacking buildroot.
All filenames UTF-8.

All MUSTS met, save the .desktop question.

Also, package runs and has no wierd file deps.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list