[Bug 229591] Review Request: lshw - Hardware Lister (lshw)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lshw - Hardware Lister (lshw)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229591





------- Additional Comments From wolfy at nobugconsulting.ro  2007-05-16 16:42 EST -------
The spec provided by the link in comment #12 contains the string @VERSION@
instead of the current version, which makes it unusable.


I have built in mock the src.rpm from comment #11 and I have found the following
issues:
- the release field does not use %dist. It is not mandatory and you are allowed
to not use it, but in this case it would be useful to provide a reason for
avoiding to use it
- Source 0 is not available
(http://www.ezix.org/software/files/lshw-0.20070516152048.tar.gz)
Please fix the path.
- /usr/bin/install is part of the default buildroot, no need to specifically
request it via BR
- timestamps of the files included (docs mostly) are not preserved; usually this
can be solved using "cp -p" or "install -p", as needed (for instance you could
probably add INSTALL="%__install -p" to the make commands )
- the generated debuginfo rpm is empty. You should patch the Makefiles and
remove the references to strip. In addition to that, at the first glance it
looks like the "STRIP=/bin/true" lines from %install are useless
- the changelog has not been updated to reflect the current version of the spec


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.