[Bug 240642] Review Request: pidgin-libnotify - Libnotify Pidgin plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pidgin-libnotify - Libnotify Pidgin plugin


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240642





------- Additional Comments From peter at thecodergeek.com  2007-05-19 03:52 EST -------
(In reply to comment #1)
> ? While you renamed the package name to pidgin-libnotify,
>   why did you leave the name of the module as gaim-libnotify.so
>   and gettext .mo files as gaim-libnotify??

The current patch merely fixes it to build against the new API of
Pidgin/Libpurple. The output shared library and gettext modules are not renamed
because it did not seem necessary to do so to provide the functionality of the
plugin (and would increase the amount of downstream patching for an
insignificant benefit).
 

> * Why do you have this package provide "gaim-libnotify = 0.12-6",
>   not gaim-libnotify = %{version}-%{release}" ?

Hmm. I don't remember why I hardcoded those. :) Fixed in 0.12-7, and the files
are on my webspace:

Spec: http://thecodergeek.com/downloads/fedora/SPECs/pidgin-libnotify.spec
SRPM:
http://thecodergeek.com/downloads/fedora/SRPMs/pidgin-libnotify-0.12-7.fc7.src.rpm

(In reply to comment #2)
> * And also check documentation. At least the contents
>   of README should be fixed.

I didn't include the README because it contains nothing relevant to this
package, just a brief description (which the RPM information already contains)
and some generic build instructions (which are unnecessary for end-users):

"gaim-libnotify

About
=====
Gaim-libnotify provides a libnotify interface to Gaim

INSTALL
=======
./configure --with-gaim=PATH/TO/GAIM
make
make install"

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.