[Bug 238705] Review Request: avr-gcc - Cross Compiling GNU GCC targeted at avr

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: avr-gcc - Cross Compiling GNU GCC targeted at avr


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238705





------- Additional Comments From rc040203 at freenet.de  2007-05-20 01:50 EST -------
MUSTFIX: 
* package doesn't honour RPM_OPT_FLAGS

Override CC at configuration time to achieve this:
CC="%{__cc} ${RPM_OPT_FLAGS}" \
... configure ...

* You are patching GCC, i.e. shipping a modified GCC.
It's GCC convention to alter the id strings (c.f. gcc -v) to denote that your
GCC is not the FSF's GCC.
c.f. gcc/version.c

[In my packages, I am changing VERSUFFIX]

CONSIDER:
* You are using monolytic gcc tarball. Using the gcc-core and gcc-g++ tarballs
instead cuts down the size of *.src.rpm and diskspace required to build by
several GBs.

* You are applying patches to GCC. This can kills critical timestamps.
To be on the safe side, you should run contrib/gcc_update inside of the expanded
GCC source tree.

* smp-flags. In general, building GCC is not smp-safe. However, you are only
building a subset from GCC which is likely not to suffer from such issues, so 
this might not hit or apply to this package.

* Check and consider to remove
/usr/lib/gcc/avr/4.1.2/install-tools
/usr/libexec/gcc/avr/4.1.2/install-tools
Normally, these are not useful for embedded cross-compilers.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.