[Bug 239924] Review Request: xournal - Take notes, sketch and annotate PDFs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xournal - Take notes, sketch and annotate PDFs
Alias: xournal

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239924





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-05-21 04:35 EST -------
* MUST/Should fix
? Question
! Suggestion/Note/etc

For 0.3.3-2:
* macros
  - Please choose to either use or not use macros for 
    commands.
    For example, you use %{__install} instead of "install",
    while you use "make" "rm" "mkdir -p" "ln -s" "cat"
    directly.

* Timestamps
  - Keep timestamps on files which are not created or
    modified during rebuild.
    * Please use %{__install} with "-p" option.
    * For this package, the following usage can save
      timestamps of many files.
----------------------------------------------------------
%{__make} install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
----------------------------------------------------------

* Desktop file
  - Both category "Application" "X-Fedora" are now deprecated
    and should be removed.

! Create text files by %{__cat} vs add as Source
  - Would you consider to add text files as Source, not to
    create them by cat command at install stage?
    Adding text files as Source prevents timestamps of 
    those files from being changed for each rebuild.

! Possible mistake in the future
  - The build log says:
------------------------------------------------------------------
gcc <snip> -DPACKAGE_LOCALE_DIR=\""/usr//locale"\" <snip>
------------------------------------------------------------------
    Currently this package does not have any gettext .mo
    files so this is not a problem, however when any .mo files
    are added in the future, please fix this so that
    "PACKAGE_LOCALE_DIR" correctly points to %{_datadir}/locale.

* Substantially duplicate files
  - The files under (doc)/manual.html, (doc)/pixmaps/ and
    those under %{_datadir}/%{name}/html-doc/, 
    %{_datadir}/%{name}/pixmaps/ are the same and either of
    them (perhaps formar) should be removed.

* Unnecessary scriptlets
  - The following is not needed because the commands in the
    scriptlets are called with || :
-----------------------------------------------------------------
Requires(post):      desktop-file-utils >= 0.8
Requires(postun):     desktop-file-utils >= 0.8
-----------------------------------------------------------------

* Source URL
  - Specify the URL of Source1/2, otherwise write as a comment
    how you created Source1/2.

* configure call
  - During the build, configure is called twice. Please call
    one time
    (According to autogen.sh, this may be solved by setting
     NOCONFIGURE).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.