[Bug 226222] Merge Review: oprofile

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: oprofile


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226222


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium




------- Additional Comments From wcohen at redhat.com  2007-05-21 11:19 EST -------
Going through the list on:

http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Results of rpmlint
$ rpmlint oprofile-0.9.2-8.fc8.src.rpm 
W: oprofile buildprereq-use qt-devel
W: oprofile buildprereq-use libxslt
W: oprofile buildprereq-use docbook-style-xsl
W: oprofile buildprereq-use docbook-utils
W: oprofile buildprereq-use elinks
W: oprofile buildprereq-use gtk2-devel
W: oprofile buildprereq-use automake
W: oprofile buildprereq-use binutils-devel
W: oprofile mixed-use-of-spaces-and-tabs (spaces: line 76, tab: line 83)

Need static package.
- MUST: Static libraries must be in a -static package.


There is a GUI application for OProfile which doesn't follow the following

- MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. This is described in
detail in the desktop files section of Packaging Guidelines. If you
feel that your packaged GUI application does not need a .desktop file,
you must put a comment in the spec file with your explanation.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.