[Bug 240635] Review Request: mash - tree creation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mash - tree creation tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240635


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kevin at tummy.com
               Flag|                            |fedora-review?




------- Additional Comments From kevin at tummy.com  2007-05-21 23:05 EST -------
Here's a review:

OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
See below - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
? - Should package latest version

Issues:

1. Cosmetic/nonblocker:
Summary:        Buildsystem -> tree converter
seems a bit terse... perhaps:
Summary:        Koji buildsystem to yum repository converter
?

2. ChangeLog and README are 0 length. Should they be shipped?
Should they have content?

3. The Source0 URL doesn't seem to work. Seems to have lots of older versions, but
not this one. Perhaps it should point to the hosted site?

4. The URL seems to give:
Environment not found

5. rpmlint says:
E: mash non-executable-script /usr/lib/python2.5/site-packages/mash/multilib.py 0644
E: mash non-executable-script /usr/lib/python2.5/site-packages/mash/config.py 0644
E: mash non-executable-script /usr/lib/python2.5/site-packages/mash/__init__.py 0644

Should these have no #! line? or should they be 755?

E: mash zero-length /usr/share/doc/mash-0.1.8/ChangeLog
E: mash zero-length /usr/share/doc/mash-0.1.8/README

See comment #2.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.