[Bug 239303] Review Request: libgii - Input library for GGI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libgii - Input library for GGI


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239303


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2007-05-22 01:54 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMs.
+ source files match upstream.
e002b3b3b7fae2b2558fe7ac854359b7  libgii-1.0.2.src.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text is NOT included in package.
+ %doc is small so no need of -doc subpackage.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ no .pc files are present.
+ -devel subpackage exists.
+ no .la files.
+ no translations available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Provides: config(libgii) = 1.0.2-1.fc7 file.so keytrans.so libgg.so.1
libgii.so.1 linux_evdev.so linux_joy.so linux_kbd.so linux_mouse.so lk201.so
mouse.so null.so save.so spaceorb.so stdin.so tcp.so


SHOULD: Ask upstream to include License text file in tarball. There is already
one packaging draft submitted on how to request upstream to include license in
their tarballs.


APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.