[Bug 230316] Review Request: jbrout - Photo manager, written in python/pygtk under the GPL licence

bugzilla at redhat.com bugzilla at redhat.com
Tue May 22 15:52:13 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jbrout - Photo manager, written in python/pygtk under the GPL licence


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230316





------- Additional Comments From bjohnson at symetrix.com  2007-05-22 11:52 EST -------
A couple of suggestions before we get started here.

1) I would remove all remnants of the svn directory structure immediately after
unpacking the archive.  That will relieve you from jumping through extra hoops
like: find plugins -type f -not -regex '.*\.svn\/.*'

2) It would probably be easier to set the file modes and clean up the shebang
and \r from files as the next step.  I see you are setting the mode (sometimes
redundantly) in multiple locations.

3) You makefile should not copy the .po or .pot files to the buildroot.  That
will also make these lines unnecessary:
%{_datadir}/locale/po/fr/LC_MESSAGES/jbrout.po
%{_datadir}/locale/po/jbrout.pot

4) Why no %doc:
#%doc changelog.txt readme.txt SciTE.properties

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list