[Bug 187243] Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lazarus : IDE and RAD tool for the free pascal compiler (fpc)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187243


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?




------- Additional Comments From jpmahowald at gmail.com  2007-05-23 22:01 EST -------
Rebuilt 0.9.20-2 on devel x86_64, it doesn't generate debuginfo.

>From mock's build.log:

extracting debug info from
/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib64/lazarus/tools/svn2revisioninc
Failed to write file: invalid section entry size
eu-strip: while writing
'/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib/debug/usr/lib64/lazarus/tools/svn2revisioninc.d
ebug': invalid section entry size
extracting debug info from
/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib64/lazarus/lazarus
Failed to write file: invalid section entry size
eu-strip: while writing
'/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib/debug/usr/lib64/lazarus/lazarus.debug':
invalid
 section entry size
extracting debug info from
/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib64/lazarus/startlazarus
Failed to write file: invalid section entry size
eu-strip: while writing
'/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib/debug/usr/lib64/lazarus/startlazarus.debug':
in
valid section entry size
extracting debug info from
/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib64/lazarus/lazbuild
Failed to write file: invalid section entry size
eu-strip: while writing
'/var/tmp/lazarus-0.9.20-2.fc7-root-mockbuild/usr/lib/debug/usr/lib64/lazarus/lazbuild.debug':
invali
d section entry size
0 blocks


I would appreciate at least a comment in the spec that indicates stripping seems
to be broken on x86_64.



rpmlint:

W: lazarus invalid-license GPL, MPL and modified LGPL
W: lazarus-debuginfo invalid-license GPL, MPL and modified LGPL
Ignore, Accepting this license.

W: lazarus setup-not-quiet
Optional.

W: lazarus mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10)
Fix please.

E: lazarus non-executable-script /usr/lib64/lazarus/debian/prerm.ex 0644
E: lazarus non-executable-script /usr/lib64/lazarus/debian/postinst.ex 0644
E: lazarus non-executable-script /usr/lib64/lazarus/debian/init.d.ex 0644
E: lazarus non-executable-script /usr/lib64/lazarus/debian/emacsen-remove.ex 0644
E: lazarus non-executable-script /usr/lib64/lazarus/debian/emacsen-install.ex 0644
E: lazarus non-executable-script /usr/lib64/lazarus/debian/postrm.ex 0644
E: lazarus non-executable-script
/usr/lib64/lazarus/tools/install/cross_unix/debian_crosswin32/postrm 0644
E: lazarus non-executable-script /usr/lib64/lazarus/debian/preinst.ex 0644
We're not doing debs, remove directory please.

E: lazarus zero-length
/usr/lib64/lazarus/components/codetools/examples/scanexamples/empty.inc
E: lazarus zero-length /usr/lib64/lazarus/lcl/interfaces/carbon/carbonimages.lrs
Ignore.

E: lazarus devel-dependency gdk-pixbuf-devel
Ignore, required to use lazarus.

W: lazarus unstripped-binary-or-object /usr/lib64/lazarus/tools/svn2revisioninc
W: lazarus unstripped-binary-or-object /usr/lib64/lazarus/lazarus
W: lazarus unstripped-binary-or-object /usr/lib64/lazarus/startlazarus
W: lazarus unstripped-binary-or-object /usr/lib64/lazarus/lazbuild
E: lazarus-debuginfo empty-debuginfo-package
The mentioned strip problem. Please document in the spec.

E: lazarus statically-linked-binary /usr/lib64/lazarus/tools/svn2revisioninc
Given it's pascal and you indicated these are static, ignore.



Ran lazarus, seemed OK from a cursory glance.

Doesn't use %find_lang, but it's a bunch of .po files dropped in a dir lazarus
uses. Ignore.

tools/install/rpm  comes with some older spec templates. What to do about them,
given that's not the .spec we are using?


Good:
Follows naming guidelines
Licenses
Source matches
Builds on x86_64
Owns all directories, no duplicate files
Uses macros
%defattr good
%clean good

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.