[Bug 240616] Review Request: pixman - pixel manipulation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pixman - pixel manipulation library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240616





------- Additional Comments From ajackson at redhat.com  2007-05-24 13:58 EST -------
(In reply to comment #1)
> mock build is fine for i386 but
> -----------------------------------------------------
> rpmlint complains on SRPM as =>
> I: pixman checking
> W: pixman mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 3)
> The specfile mixes use of spaces and tabs for indentation, which is a
> cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

Fixed.

> rpmlint output on pixman RPM =>
> W: pixman no-documentation
> The package contains no documentation (README, doc, etc).
> You have to include documentation files.

... if they exist, yes.  But there's no upstream documentation to include.  The
package guidelines do not say you must have docs, only that relevant docs must
be included if they exist:

http://fedoraproject.org/wiki/Packaging/Guidelines#head-9bbfa57478f0460c6160947a6bf795249488182b

> E: pixman library-without-ldconfig-postin /usr/lib/libpixman.so.0.0.0
> This package contains a library and provides no %post scriptlet containing
> a call to ldconfig.
> 
> E: pixman library-without-ldconfig-postun /usr/lib/libpixman.so.0.0.0
> This package contains a library and provides no %postun scriptlet containing
> a call to ldconfig.
> 
> rpmlint outout on -devel rpm =>
> W: pixman-devel summary-not-capitalized pixman development package
> Summary doesn't begin with a capital letter.

All fixed.

I usually leave disttag off until initial import, if for no other reason than 
cvs-import.sh would historically not expand disttag properly on initial import,
so I had to edit the spec after import anyway.  Will certainly use once it's in
CVS though.

New spec and srpm, with all above addressed plus updated snapshot:
http://people.redhat.com/ajackson/pixman/pixman.spec
http://people.redhat.com/ajackson/pixman/pixman-0.9.0-20070524.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.