[Bug 199405] Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vtk - The Visualization Toolkit - A high level 3D visualization library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199405





------- Additional Comments From ed at eh3.com  2007-05-28 10:27 EST -------
Hi Axel, may sincere apologies for the delays.  I've been using your VTK 
package for a few weeks and it appears to function nicely for me.  Here
is a quick review:

GOOD:
+ source matches upstream -- sha1sum:
   0a574f481c65a3d188c48dfc4e284aa8f70bad84  vtk-5.0.2.tar.gz.1
   0a574f481c65a3d188c48dfc4e284aa8f70bad84  vtk-5.0.2.tar.gz
+ spec is correctly named, legible, and appears to meet the guidelines
+ license OK and correctly included
+ package builds in mock on FC6-x86_64 using the one small change:

   %{!?python_sitearch: %global python_sitearch ...

+ proper use of ldconfig
+ dir ownership looks OK
+ proper use of %clean in spec and at start of %install
+ proper use of -devel, -examples, etc.
+ no *.la

NEEDSWORK:
+ Please put the /usr/include/* files in /usr/include/vtk/* or a 
  similar location since some have rather generic names (e.g.,
  "internal") and there are a large number of them
+ rpmlint reports a number of warnings/errors and they are attached:
  + it would be nice to remove a lot of the unnecessary 
    executable permissions
  + the "vtk hardcoded-library-path in %{_prefix}/lib/*" looks 
    fine to me -- its just brain-dead parsing from rpmlint

Please consider the /usr/include/vtk subdir and I'll approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.