[Bug 223422] Review Request: mrxvt - Multi-tabbed terminal emulator.

bugzilla at redhat.com bugzilla at redhat.com
Thu May 31 11:06:20 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mrxvt - Multi-tabbed terminal emulator.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422





------- Additional Comments From gnome at dux-linux.org  2007-05-31 07:06 EST -------
OK.  I've followed the guidelines and built new rpms.  Please find the new rpms,
spec file, and desktop file here:

http://littlehat.homelinux.org:8000/FEDORA/mrxvt/0.5.2-1/

Also, here is the latest rpmlint:

[a at laptop mrxvt_devel]$ sudo rpmlint
/usr/src/redhat/RPMS/i386/mrxvt-0.5.2-1.i386.rpm
W: mrxvt incoherent-version-in-changelog 1 0.5.2-1
W: mrxvt wrong-file-end-of-line-encoding /usr/share/doc/mrxvt/scripts/mrxvt.vbs
W: mrxvt non-conffile-in-etc /etc/mrxvt/mrxvtrc.sample
W: mrxvt non-conffile-in-etc /etc/mrxvt/mrxvtrc
W: mrxvt non-conffile-in-etc /etc/mrxvt/submenus.menu
W: mrxvt non-conffile-in-etc /etc/mrxvt/default.menu

I believe the changelog version warning is OK considering the sources are for
0.5.2 and we don't have a minor release number (Am I incorrect?).  The
end-of-line-encoding is because it's a visual basic script -- this should be
fine b/c it shouldn't kill the build process, correct?  The non-conffile
errors...is that a big deal??? considering a user should know where to grab
example configuration information?  I know it doesn't conform to the LSB.  Is
there a precedent for including this? or should they be moved?  If they need to
be moved, can someone suggest a proper location?  As always, thanks for the help.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list