[Bug 282521] Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing


https://bugzilla.redhat.com/show_bug.cgi?id=282521





------- Additional Comments From pertusus at free.fr  2007-11-02 05:02 EST -------
The iconv calls are wrong, the encoding of the xml files in
latin1. I guess that it is the same for the .sty.
(Moreover those files should not have been shipped in the
first place).

It is better to have a relative link than an absolute one,
when it is easy to do so, as it is the case here:

ln -s ../../sgml/docbook/xsl-stylesheets/dblatex
$RPM_BUILD_ROOT%{_datadir}/dblatex/xsl

For the docs, why don't you install anything and simply have
%docs COPYRIGHT docs/manual.pdf

In the manual, it is said:
/etc/dblatex/
    System-wide configuration directory.
that's why I think it is better to own
%dir %{_sysconfdir}/dblatex


Suggestions:
To catch all kind of compression and no compression, replace
%{_mandir}/man1/dblatex.1.gz with
%{_mandir}/man1/dblatex.1*

The BuildRequires python is redundant with python-devel.
The Requires python is autodetected (and versioned automatically),
so it is not needed, at least on recent fedora.

there is a tab and space rpmlint warning that you can ignore, or not:
dblatex.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12)


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.