[Bug 282521] Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing

Sat Nov 3 00:40:00 UTC 2007

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dblatex - DocBook to LaTeX/ConTeXt Publishing

https://bugzilla.redhat.com/show_bug.cgi?id=282521

------- Additional Comments From ndbecker2 at gmail.com  2007-11-02 20:40 EST -------
(In reply to comment #39)
> The iconv calls are wrong, the encoding of the xml files in
> latin1. I guess that it is the same for the .sty.
> (Moreover those files should not have been shipped in the
> first place).

I'm sorry, I don't understand what you're asking me to do here.

> It is better to have a relative link than an absolute one,
> when it is easy to do so, as it is the case here:
> 
> ln -s ../../sgml/docbook/xsl-stylesheets/dblatex
> $RPM_BUILD_ROOT%{_datadir}/dblatex/xsl

Done.

> 
> For the docs, why don't you install anything and simply have
> %docs COPYRIGHT docs/manual.pdf

Sorry, I don't understand. 

> In the manual, it is said:
> /etc/dblatex/
>     System-wide configuration directory.
> that's why I think it is better to own
> %dir %{_sysconfdir}/dblatex

Done.

> 
> Suggestions:
> To catch all kind of compression and no compression, replace
> %{_mandir}/man1/dblatex.1.gz with
> %{_mandir}/man1/dblatex.1*

Done.

> The BuildRequires python is redundant with python-devel.
> The Requires python is autodetected (and versioned automatically),
> so it is not needed, at least on recent fedora.

OK.

> there is a tab and space rpmlint warning that you can ignore, or not:
> dblatex.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12)
> 

OK, Please see:
https://nbecker.dyndns.org/RPM/dblatex-0.2.7-11.fc8.src.rpm
https://nbecker.dyndns.org/RPM/dblatex.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.