[Bug 369501] Review Request: ruby-flexmock - Mock object library for ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-flexmock - Mock object library for ruby


https://bugzilla.redhat.com/show_bug.cgi?id=369501





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-11-07 06:48 EST -------
For 0.7.1-1:

* Virtual provides of ruby modules - unversioned-explicit-provides
  - At least this should have Provides: ruby(LIBRARY) = VERSION,
    not only ruby(LIBRARY) (ref:
    http://fedoraproject.org/wiki/Packaging/Ruby )

* Source0 URL
  - Please specify full URL of Source0.

* CFLAGS
  - Why does CFLAGS in %build section needed?
    This is noarch and actually this does not seem to
    do anything.

* Many non-executable-script complaints
  - Usually the permissions 0644 are correct, these scripts should
    not have shebangs.

* spurious-executable-perm 
  /usr/share/doc/ruby-flexmock-0.7.1/GoogleExample.rdoc
  - Perhaps the permisson of this file should be 0644.

* License
  - IMO this is "Copyright only", according to
    http://fedoraproject.org/wiki/Licensing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.