[Bug 307891] libvpd - C++ library for system vpd access

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 7 12:54:09 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: libvpd - C++ library for system vpd access


https://bugzilla.redhat.com/show_bug.cgi?id=307891





------- Additional Comments From bugs.michael at gmx.net  2007-11-07 07:54 EST -------
$ rpmlint libvpd-1.4.0-2.src.rpm 
libvpd.src:17: W: unversioned-explicit-provides libvpd_cxx


> #! /usr/bin/rpm

What's that? Spec files are not executable, RPM is at /bin/rpm,
and you cannot execute a spec file via rpm anyway.


> %define name libvpd
> %define version 1.4.0

These are completely redundant, because %{name} and %{version}
are defined by the following tags already:

Name:		%{name}
Version:	%{version}


> %configure --prefix=%{_prefix}/ --disable-static

The --prefix=/usr is default, see:  rpm --eval %configure


> /usr/bin/make %{?_smp_mflags}

Use just "make" in $PATH or %{__make}


> %clean 
> /bin/rm -rf $RPM_BUILD_ROOT

Same here. Prefer "rm" or %{__rm}


> %doc COPYING INSTALL NEWS README TODO

The INSTALL file is irrelevant to RPM package users.


> %exclude %{_libdir}/*.la
> %{_libdir}/libvpd_cxx*
> %{_libdir}/libvpd*

This looks suspicious. Examining it further below.


> %files devel
> %defattr(-,root,root)
> %doc COPYING INSTALL NEWS README TODO

Don't duplicate the %doc files here, they are included in the
main package already. And -devel pkgs require the main package.

[...]

Build log warnings:

warning: File listed twice: /usr/lib/libvpd_cxx
warning: File listed twice: /usr/lib/libvpd_cxx.1
warning: File listed twice: /usr/lib/libvpd_cxx.1.0.0

$ rpmls -p libvpd-1.4.0-2.fc8.i386.rpm 
lrwxrwxrwx  /usr/lib/libvpd
lrwxrwxrwx  /usr/lib/libvpd.1
-rwxr-xr-x  /usr/lib/libvpd.1.0.0
lrwxrwxrwx  /usr/lib/libvpd_cxx
lrwxrwxrwx  /usr/lib/libvpd_cxx.1
-rwxr-xr-x  /usr/lib/libvpd_cxx.1.0.0
drwxr-xr-x  /usr/share/doc/libvpd-1.4.0
-rw-r--r--  /usr/share/doc/libvpd-1.4.0/COPYING
-rw-r--r--  /usr/share/doc/libvpd-1.4.0/INSTALL
-rw-r--r--  /usr/share/doc/libvpd-1.4.0/NEWS
-rw-r--r--  /usr/share/doc/libvpd-1.4.0/README
-rw-r--r--  /usr/share/doc/libvpd-1.4.0/TODO

Where are the linkable libvpd.so and libvpd_cxx.so? They belong
into the -devel package, but instead the main package includes
mysterious /usr/lib/libvpd and /usr/lib/libvpd_cxx without the
*.so extension.

$ rpmls -p libvpd-devel-1.4.0-2.fc8.i386.rpm |grep so
$

That's a blocker.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list