[Bug 375871] Review Request: libdvdnav - A library for reading DVD video discs based on Ogle code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libdvdnav - A library for reading DVD video discs based on Ogle code
Alias: libdvdnav

https://bugzilla.redhat.com/show_bug.cgi?id=375871





------- Additional Comments From alexl at users.sourceforge.net  2007-11-11 17:28 EST -------
(Full disclosure: this is my first review, apologies for any inconsistencies in
advance).

Everything looks OK, except that this also provides libdvdread{-devel}, is this
intended to replace the existing libdvdread{-devel}?  It seems to provide a
newer .so version.  If this isn't intended to replace then it needs to change
package name to libdvdread4 or somesuch.   Anyway, this (and possible legal
issues) are the only blockers.

Full review follows:

MUST (OK): 
• rpmlint
rpmlint libdvd*
libdvdnav.i386: W: no-url-tag
libdvdnav.i386: W: no-url-tag
libdvdnav-debuginfo.i386: W: no-url-tag
libdvdnav-devel.i386: W: no-url-tag
libdvdread.i386: W: no-documentation
libdvdread.i386: W: no-url-tag
libdvdread-devel.i386: W: no-documentation
libdvdread-devel.i386: W: no-url-tag
same for source package
• package name: OK
• spec file name: OK
• package guidelines: OK, pending FE-Legal
• license: OK GPLv2+
•  license field: OK
• license in package: OK
• spec file in US English: OK
• legible spec file: OK
• md5sum: OK
91ff52cade291e79060f87fd431fa1ab  libdvdnav-4.1.1.tar.gz
91ff52cade291e79060f87fd431fa1ab  libdvdnav-4.1.1.tar.gz

• builds on F-8, i386: OK
• BuildRequires: OK
• locales (none): OK
• ldconfig: OK
• relocatable: N/A
• owns directories it creates: OK
• no duplicate %files: OK
• %defattr: OK
• %clean: OK
• macros consistent: OK
• no content: OK
• no large doc: OK
• no runtime info in %doc: OK
• header files in -devel: OK
• no static libs: OK
• no pkgconfig: OK
• .so files only in -devel: OK
• -devel packages require base: OK
• no .la files: OK
• no desktop files needed: OK
• doesn't own other files: OK
• %install removes buildroot: OK
• filenames are valid UTF-8: OK

MUST (to fix):
• this package provides libdvdread{-devel}, is this intended to replace the
existing libdvdread? if so need to add conflicts/provides and co-ordinate with
existing maintainer of libdvdread to obsolete that package
• may need to have legal (or spot) to check that libdvdnav is OK

SHOULD (not blockers)
• license in upstream: OK
• no translations available: OK
• no scriptlets (other than %post): OK
• no files outside standard locations: OK
• build in mock: not checked yet, but can be done later

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.